Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for old versions of Puppet and Ruby in next major version? #577

Closed
cwjohnston opened this issue Nov 4, 2016 · 3 comments
Closed
Milestone

Comments

@cwjohnston
Copy link
Contributor

Description of problem

  • What did you do? Tried to add a feature
  • What happened? Tests failed on older Puppet gem version/parser
  • What did you expect to happen? Tests pass :)
  • How can someone reproduce the problem?

Command used and debugging output

See failed builds here https://travis-ci.org/sensu/sensu-puppet/builds/172202862

Platform and version information

  • Your OS:
  • Your Ruby version: 1.8.7, 1.9.3, 2.0.0
  • Your version of Puppet: 3.5 w/o future parser
  • Your version of Sensu: 0.26
  • Your version of this module: 6c927f6

Anything else to add that you think will be helpful?

I'm not sure if this project aims to follow semantic versioning, but based on the published support schedules for Puppet and Ruby, I believe its appropriate for this project to drop support for Puppet < 4.0 and Ruby < 2.0 in the next major version release. Although Puppet 4.0 supports Ruby 1.9.3 and 2.0, it is not tested on these versions of Ruby.

Although I am motivated to submit this issue by the failure of a particular pull request, I think this change makes sense going forward for the project as a whole. 😉

@jaxxstorm
Copy link
Contributor

jaxxstorm commented Nov 4, 2016

Yes, I think at this stage we've added multiple conditionals to travis just for ruby 1.8.7, and it's becoming arduous.

I think the next release (2.2.0) will be the last that supports ruby 1.8.7. Does that seem acceptable?

@cwjohnston
Copy link
Contributor Author

Makes sense to me 👍

@jaxxstorm jaxxstorm added this to the 2.3.0 milestone Nov 6, 2016
@jaxxstorm
Copy link
Contributor

Also, in addition to this, support for puppet 3.8.7 is EOL at the end of the year, so no more puppet 3 either, which means we can finally start using some of the Puppet 4 goodness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants