Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis_reconnect_on_error should default to true #685

Closed
cwjohnston opened this issue Jun 27, 2017 · 2 comments
Closed

redis_reconnect_on_error should default to true #685

cwjohnston opened this issue Jun 27, 2017 · 2 comments
Assignees
@ghoneycutt

Comments

@cwjohnston
Copy link
Contributor

Description of problem

The redis_reconnect_on_error parameter currently defaults to false, which is inconsistent with Sensu's defaults. The official Sensu documentation has incorrectly documented this default as false for some time now.

Relates to sensu/sensu-docs#601 where I've suggested a fix for the documentation.
@ghoneycutt ghoneycutt self-assigned this Jul 4, 2017
@ghoneycutt
Copy link
Collaborator

The docs should be merged before this functionality.

ghoneycutt added a commit to ghoneycutt/sensu-puppet that referenced this issue Jul 4, 2017
@ghoneycutt
(sensuGH-685) redis_reconnect_on_error now defaults to true
97ee6be 
This if to reflect an update to the API and documentation.

https://sensuapp.org/docs/latest/reference/redis.html
@ghoneycutt ghoneycutt mentioned this issue Jul 4, 2017
Merged
ghoneycutt added a commit that referenced this issue Jul 5, 2017
@ghoneycutt
Merge pull request #707 from ghoneycutt/685_redis_reconnect_on_error_…
14d52cf 
…should_default_true

(GH-685) redis_reconnect_on_error now defaults to true
@ghoneycutt
Copy link
Collaborator

Released in v2.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghoneycutt ghoneycutt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwjohnston @ghoneycutt