Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sensu::plugin does not work on windows without specifying install_path #786

Closed
ghoneycutt opened this issue Jul 28, 2017 · 2 comments
Closed

sensu::plugin does not work on windows without specifying install_path #786

ghoneycutt opened this issue Jul 28, 2017 · 2 comments
Assignees
@Phil-Friderici

Comments

@ghoneycutt
Copy link
Collaborator

sensu::plugin::install_path defaults to /etc/sensu/plugins. While you can set that if you use windows, the module should do the right thing.

We should default install_path to undef and in the defined type have a conditional that sets install_path_real to use a default if the value is undef.

This needs a sensu::plugin addition to tests/sensu-client-windows.pp where install_path is not specified so it can be validated.
Phil-Friderici added a commit to Phil-Friderici/sensu-puppet that referenced this issue Aug 3, 2017
@Phil-Friderici
(sensuGH-786) sensu::plugin does not work on windows without specifyi…
85e71ff 
…ng install_path

Add Linux/Windows sensitive default values for sensu::plugin::install_path.
Adjust calls of sensu::plugin to not set install_path anymore.
@Phil-Friderici Phil-Friderici mentioned this issue Aug 3, 2017
Merged
@Phil-Friderici
Copy link
Collaborator

Used the same logic as in main class [1] to specify install_path.
Changed the call of sensu::plugin in the main class to not specify install_path anymore.

Will continue to work on the vagrant part to validate install_path in tests\sensu-client-windows.pp.

[1] https://github.com/sensu/sensu-puppet/blob/v2.30.1/manifests/init.pp#L487-L490

Phil-Friderici added a commit to Phil-Friderici/sensu-puppet that referenced this issue Aug 3, 2017
@Phil-Friderici
(sensuGH-786) sensu::plugin does not work on windows without specifyi…
16e35cc 
…ng install_path

Add Linux/Windows sensitive default values for sensu::plugin::install_path.
Adjust calls of sensu::plugin to not set install_path anymore.
ghoneycutt added a commit that referenced this issue Aug 3, 2017
@ghoneycutt
Merge pull request #789 from Phil-Friderici/GH-768
7cc9a9b 
(GH-786) sensu::plugin does not work on windows without specifying install_path
@ghoneycutt
Copy link
Collaborator Author

Released in v2.31.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phil-Friderici Phil-Friderici

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghoneycutt @Phil-Friderici