minimum apt version wall

[Justin-DynamicD]

##minimum apt version wall
As of 2.5.0 and later, sensu-sensu now requires puppetlabs-apt > 4.0.0. This is a breaking requirement change for me (and I assume other puppet users) as there are LOTS of modules out there that still have a <3.0.0 requirement putting us in a "which module is more important" scenario. Some modules are even useful/critical for sensu itself like puppet-grafana (>=2.1.0 < 3.0.0) and puppetlabs-rabbitmq (>=1.8.0 <3.0.0).

Was the jump to 4.0 needed?

[SergK]

@Justin-DynamicD Hi, I've raised the same question #781 , so unfortunately, as workaround, I forked repo and revert the change which introduced this change.

[Justin-DynamicD]

the response of "wont fix" seems poorly thought through. If the devs are reading this I'd like to once again point out that the following module is basically needed to manage sensu with puppet yet cannot coexist with this module anymore:

puppetlabs-rabbitmq

Won't fix basically means "this module is broken until rabbitmq folks update". That's a pretty big issue.

[ghoneycutt]

Perhaps there is some confusion as @Justin-DynamicD stated that we require apt > 4 though it is actually >= 4

https://github.com/sensu/sensu-puppet/blob/master/metadata.json#L64

This is supported by puppetlabs-rabbitmq

https://github.com/voxpupuli/puppet-rabbitmq/blob/master/metadata.json#L51

[ghoneycutt]

Created voxpupuli/puppet-grafana#53 to help with the grafana module.

[madAndroid]

We're experiencing this as well... according to the style guide, soft dependencies shouldn't be declared in the metadata.json => https://docs.puppet.com/puppet/latest/style_guide.html#dependencies.

Since this is a dependency only for Debian osfamily, is this regarded as a hard depedency?

[ghoneycutt]

It is on Debian :>

I agree that it's not a hard dependency as folks running this on Windows certainly don't need to install the apt module.

[ghoneycutt]

Created #791 to remove apt from the metadata as a dependency.

[ghoneycutt]

@Justin-DynamicD did you see my notes above? I think you might be running an old version of rabbitmq.

[Justin-DynamicD]

Perhaps the notes are out of date, but if you hit the site:
https://forge.puppet.com/puppetlabs/rabbitmq/dependencies

"puppetlabs/apt (>=1.8.0 <3.0.0)".

So it looks like falling back on the site vs. digging into the code may be the concern?

[SergK]

Regarding rabbitmq, yes, they bump apt module version, but haven't release it yet, so it's on master branch only

[ghoneycutt]

We dropped apt as a hard dependency in v2.31.0

[madAndroid]

@ghoneycutt - awesome, thank you