Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roundrobin subscriptions on Windows aren't configured #820

Closed
bodgit opened this issue Oct 2, 2017 · 3 comments · Fixed by #846
Closed

Roundrobin subscriptions on Windows aren't configured #820

bodgit opened this issue Oct 2, 2017 · 3 comments · Fixed by #846
Labels
bug

Comments

@bodgit
Copy link
Contributor

bodgit commented Oct 2, 2017

Description of problem

  • What did you do?

Applied the following on a Windows host:

::sensu::subscription { 'roundrobin:foo':
  ensure => present,
}
  • What happened?

A zero-length file C:\opt\sensu\conf.d\subscription_roundrobin is created

  • What did you expect to happen?

The subscription should be created, with a suitable filename.

  • How can someone reproduce the problem?

It looks like the subscription name should be sanitised as while the : character is fine in filenames on !Windows, it has special meaning as a drive letter separator which likely explains why the filename is truncated.

Platform and version information

  • Your OS: Windows 2012r2
  • Your version of Puppet: 4.10.0
  • Your version of Sensu: 1.0.2
  • Your version of this module: 2.35.0
@ghoneycutt ghoneycutt added the bug label Oct 2, 2017
@alvagante
Copy link
Collaborator

@ghoneycutt giving a look to this

alvagante added a commit to alvagante/sensu-puppet that referenced this issue Nov 21, 2017
@alvagante
Fix for sensu#820
a0ef8c4
@alvagante alvagante mentioned this issue Nov 21, 2017
Merged
4 tasks
alvagante added a commit to alvagante/sensu-puppet that referenced this issue Dec 4, 2017
@alvagante
Solves sensu#820
6f6fce0 
Fix for sensu#820

FIxed sensu_client_subscription type

Added regexp explanation and vagrant test
@alvagante
Copy link
Collaborator

@bodgit can you confirm that #846 solves the issue?

ghoneycutt added a commit that referenced this issue Jan 4, 2018
@ghoneycutt
Merge pull request #846 from alvagante/820
94b0f03 
Fix #820
@ghoneycutt
Copy link
Collaborator

Released in v2.43.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #820 alvagante/sensu-puppet
3 participants
@alvagante @ghoneycutt @bodgit