-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hooks #836
Comments
|
Thanks for letting us know, much appreciated! |
|
@dzeleski Please give a look to the linked commit and possibly let me know if it does all you need. |
|
@dzeleski please open a separate issue for this. Please use the current version, v2.38.1, before submitting. |
|
Done, added PR. Have not tested and I will not be able to until first thing tomorrow as I have to leave the office here in a few min. Edit: Deleted unrelated comments they can be found in #838 |
Added check for valid hooks names Added hooks use explanation in README
|
@alvagante dzeleski tested the hook functionality last night and it worked. |
|
Thank you everyone for your help getting this implemented!! Released in v2.39.0 |
Currently it appears this module does not support hooks. As this was released in 1.1 I assume others will start wanting to use it at some point. We are trying to start testing them now which is how we ran into it. Basically just wanted to get this open to track the feature, I will attempt to get a PR going if I have some free time later this week.
The text was updated successfully, but these errors were encountered: