Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hooks #836

Closed
dzeleski opened this issue Nov 1, 2017 · 7 comments
Closed

Implement hooks #836

dzeleski opened this issue Nov 1, 2017 · 7 comments
Assignees
Labels

Comments

@dzeleski
Copy link
Contributor

dzeleski commented Nov 1, 2017

Currently it appears this module does not support hooks. As this was released in 1.1 I assume others will start wanting to use it at some point. We are trying to start testing them now which is how we ran into it. Basically just wanted to get this open to track the feature, I will attempt to get a PR going if I have some free time later this week.

@ghoneycutt
Copy link
Collaborator

Thanks for letting us know, much appreciated!

alvagante added a commit to alvagante/sensu-puppet that referenced this issue Nov 4, 2017
@alvagante alvagante mentioned this issue Nov 4, 2017
4 tasks
@alvagante
Copy link
Collaborator

@dzeleski Please give a look to the linked commit and possibly let me know if it does all you need.
I've tested it locally, with sample hooks data similar to the documentation example, and it behaves as expected, but a double check from real world use cases would be welcomed.

@ghoneycutt
Copy link
Collaborator

@dzeleski please open a separate issue for this. Please use the current version, v2.38.1, before submitting.

@dzeleski
Copy link
Contributor Author

dzeleski commented Nov 6, 2017

Done, added PR. Have not tested and I will not be able to until first thing tomorrow as I have to leave the office here in a few min.

Edit: Deleted unrelated comments they can be found in #838

alvagante added a commit to alvagante/sensu-puppet that referenced this issue Nov 7, 2017
Added check for valid hooks names

Added hooks use explanation in README
@csabo
Copy link

csabo commented Nov 7, 2017

@alvagante dzeleski tested the hook functionality last night and it worked.

@dzeleski
Copy link
Contributor Author

dzeleski commented Nov 7, 2017

@csabo there are further updates in #837

ghoneycutt added a commit that referenced this issue Nov 7, 2017
@ghoneycutt
Copy link
Collaborator

Thank you everyone for your help getting this implemented!!

Released in v2.39.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants