Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for disabling the TCP/UDP Socket entirely #902

Closed
jaredledvina opened this issue May 7, 2018 · 3 comments · Fixed by #905
Closed

Feature Request: Support for disabling the TCP/UDP Socket entirely #902

jaredledvina opened this issue May 7, 2018 · 3 comments · Fixed by #905

Comments

@jaredledvina
Copy link
Contributor

New in Sensu 1.3.0 is the ability to disable the TCP/UDP socket entirely: https://github.com/sensu/sensu/blob/master/CHANGELOG.md#130---2018-03-09

Currently, it looks like this module, hard codes configuring the TCP/UDP socket here: https://github.com/sensu/sensu-puppet/blob/master/manifests/client.pp#L102-L105

Ideally, it'd be setup similar to the http_socket allowing it to be completely disabled.

@ghoneycutt
Copy link
Collaborator

So setting client_bind and client_port to undef does not work, instead the socket_config should be missing entirely, is that correct?

@jaredledvina
Copy link
Contributor Author

jaredledvina commented May 7, 2018

So, when I wrote https://github.com/sensu/sensu/pull/1800/files, I matched how the http_socket worked, where you have to pass in:

{
  "client": {
    "http_socket": {
      "enabled": false
    }
  }
}

to totally disable it, so for the TCP/UDP socket it's:

{
  "client": {
    "socket": {
      "enabled": false
    }
  }
}

let me know if that helps!
https://github.com/sensu/sensu/blob/master/lib/sensu/client/process.rb#L501 for the http_socket code that's relevant as well.

treydock added a commit to treydock/sensu-puppet that referenced this issue May 9, 2018
treydock added a commit to treydock/sensu-puppet that referenced this issue May 9, 2018
ghoneycutt added a commit that referenced this issue May 21, 2018
(GH-902) Add client_socket_enabled boolean parameter
@ghoneycutt
Copy link
Collaborator

Released in v2.53.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants