Remove hardcoded /etc/sensu #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hardcoded /etc/sensu and respect changes to sensu::etc_dir Co-authored-by: Nemanja Delic <nemanjad@ccbill.com> Co-authored-by: Trey Dockendorf <treydock@gmail.com>
|
@treydock are there other tests you are going to add or is this ready? |
|
@ghoneycutt I'm content with existing tests because they verify that these changes didn't mess with default behavior. What we're not testing is what happens when |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Several places in code did not respect changes to
sensu::etc_dir, this change removes hardcoded/etc/sensuand/etc/sensu/conf.dfrom several locations.Related Issue
Replaces #1058
Motivation and Context
Support changing
sensu::etc_dirand other resources doing the right thing.How Has This Been Tested?
Existing unit tests verify these changes don't change behavior but don't actually verify that changes to
sensu::etc_dirdo what the changes intended, those will be added.