Add env_vars parameter #1088
Add env_vars parameter #1088
Conversation
| @@ -28,6 +28,8 @@ | |||
| # | |||
| # @param path Used to set PATH in /etc/default/sensu | |||
| # | |||
| # @param env_vars Additional environment variables for /etc/default/sensu | |||
There was a problem hiding this comment.
why is this specified in two places since there is only one /etc/default/sensu ?
There was a problem hiding this comment.
Was just following convention of parameters being documented in sensu and sensu::package. Since sensu::package is private I think having in sensu is sufficient.
There was a problem hiding this comment.
Want me to remove or leave? All the other parameters in sensu::package are documented in 2 places.
There was a problem hiding this comment.
why is the param in both?
There was a problem hiding this comment.
The public access is in sensu class and the sensu::package parameter pulls the value from $::sensu::env_vars so that template can use @env_vars. Also just how all the parameters in sensu::package are handled, was just following the convention. Could define in just sensu class and access via scope['sensu::env_vars'] in template but this would be the first time that pattern is used for parameters.
Pull Request Checklist
Description
Add
env_varsparameter that provides environment variables to/etc/default/sensu.Related Issue
Fixes #1074
Motivation and Context
Support arbitrary environment variables in
/etc/default/sensu.