Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort array properties before comparison #303

Merged
merged 1 commit into from
Jan 27, 2015
Merged

Sort array properties before comparison #303

merged 1 commit into from
Jan 27, 2015

Conversation

dpeters
Copy link
Contributor

@dpeters dpeters commented Jan 26, 2015

The order of properties can be different when a catalog is compiled by a
different puppet master (i.e. clustered puppet masters).

Sorting in the type should prevent resources from being updated just to
change the sort order of an array.

@dpeters
Sort array properties before comparison
cb9de52 
The order of properties can be different when a catalog is compiled by a
different puppet master (i.e. clustered puppet masters).

Sorting in the type should prevent resources from being updated just to
change the sort order of an array.
@jlambert121
Copy link
Contributor

Thanks for the PR!

jlambert121 added a commit that referenced this pull request Jan 27, 2015
@jlambert121
Merge pull request #303 from dpeters/sort_properties
1a76727 
Sort array properties before comparison
@jlambert121 jlambert121 merged commit 1a76727 into sensu:master Jan 27, 2015
thejandroman pushed a commit to Ensighten/sensu-puppet that referenced this pull request Aug 2, 2016
Allow undef handlers and subscribers
e6211df 
This commit fixes the error message: `undefined method `sort' for
nil:NilClass`. This error message can be seen when either the handlers
or subscribers parameters are passed in as  `undef` in the check.pp
manifest.

The PRs that looks like they introduced this behavior are:
sensu#285
sensu#303
@thejandroman thejandroman mentioned this pull request Aug 2, 2016
Merged
thejandroman pushed a commit to Ensighten/sensu-puppet that referenced this pull request Aug 5, 2016
Allow undef handlers and subscribers
a7b9b4b 
This commit fixes the error message: `undefined method `sort' for
nil:NilClass`. This error message can be seen when either the handlers
or subscribers parameters are passed in as  `undef` in the check.pp
manifest.

The PRs that looks like they introduced this behavior are:
sensu#285
sensu#303
@thejandroman thejandroman mentioned this pull request Aug 5, 2016
Merged
thejandroman pushed a commit to Ensighten/sensu-puppet that referenced this pull request Aug 18, 2016
Allow undef handlers and subscribers
29740a1 
This commit fixes the error message: `undefined method `sort' for
nil:NilClass`. This error message can be seen when either the handlers
or subscribers parameters are passed in as  `undef` in the check.pp
manifest.

The PRs that looks like they introduced this behavior are:
sensu#285
sensu#303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpeters @jlambert121