add option to purge plugins directory #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yyejun thanks - this fixes the issue with the previous implementation. I think we need to default purge to false though (avoid breaking current installations and those that use packages to install plugins). Also could you throw some tests around it and it'll be good to go! |
|
@jlambert121 thanks. Updated as you suggested. |
|
Awesome - thanks! |
jlambert121
added a commit
that referenced
this pull request
Feb 26, 2015
add option to purge plugins directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/etc/sensu/plugins is not purged by puppet even when manage manage_plugins_dir is set to true. This seems very counterintuitive to me.