Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 385, add owner group sensu:sensu to plugins dir and plugins files #386

Merged
merged 1 commit into from
Jul 29, 2015

Conversation

hurrycaine
Copy link
Contributor

ensure sensu:senu is owner of plugins_dir for type directory and plugin files for type url fixed #385

@hurrycaine
Copy link
Contributor Author

Not sure what is going on with all the failures ...its failing before it gets to the tests and nothing like that was changed. Do not think we got a valid test.

The errors start very early
line 129
FAILED: tar -Pzxf /home/travis/.casher/fetch.tgz /home/travis/build/sensu/sensu-puppet/vendor/bundle
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

It fails right before the tests are ran with ...

"spec/defines/sensu_handler_spec.rb" "spec/defines/sensu_plugin_spec.rb" "spec/defines/sensu_subscription_spec.rb" "spec/unit/puppet_x_sensu_totype_spec.rb" "spec/unit/sensu_redis_config_spec.rb"
*** Mocha deprecation warning: require 'mocha/standalone' has been deprecated. Please use require 'mocha/api' instead. /home/travis/build/sensu/sensu-puppet/vendor/bundle/ruby/2.0.0/gems/rspec-core-2.0.0/lib/rspec/core/mocking/with_mocha.rb:2:inrequire': cannot load such file -- mocha/object (LoadError)

@hurrycaine
Copy link
Contributor Author

The previous good Travice CI build user rspec 2.99.0
this build used 2.0.0

I was able to test this locally by removing my Gemfile.lock and adding rspec version 2.0.0 before rspec-puppet.

gem 'rspec', "2.0.0", :require => false

I could not get rspec-puppet to pull down rspec 2.0.0 any other way, no idea why it happened here.
Maybe it was an aberration? I am not sure how to rerun the travis build. I could add rspec ~> 2.99.0 to enforce it...

@hurrycaine hurrycaine closed this Jul 18, 2015
@hurrycaine hurrycaine reopened this Jul 18, 2015
@hurrycaine
Copy link
Contributor Author

Closing and reopening to trigger a new build ... no luck all failed again

@jlambert121
Copy link
Contributor

That's annoying, I should revisit my PR where I updated some gems and travis config - might fix this as well.

@jlambert121
Copy link
Contributor

Can you rebase and see if that fixes the tests?

@hurrycaine
Copy link
Contributor Author

Done. I did have to fix a trailing comma for ruby 1.8.7 rspec after all!

jlambert121 added a commit that referenced this pull request Jul 29, 2015
fixed 385, add owner group sensu:sensu to plugins dir and plugins files
@jlambert121 jlambert121 merged commit 4e35b3f into sensu:master Jul 29, 2015
@jlambert121
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins directory permissions inconsistent
2 participants