-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed 385, add owner group sensu:sensu to plugins dir and plugins files #386
Conversation
|
Not sure what is going on with all the failures ...its failing before it gets to the tests and nothing like that was changed. Do not think we got a valid test. The errors start very early It fails right before the tests are ran with ... "spec/defines/sensu_handler_spec.rb" "spec/defines/sensu_plugin_spec.rb" "spec/defines/sensu_subscription_spec.rb" "spec/unit/puppet_x_sensu_totype_spec.rb" "spec/unit/sensu_redis_config_spec.rb" |
|
The previous good Travice CI build user rspec 2.99.0 I was able to test this locally by removing my Gemfile.lock and adding rspec version 2.0.0 before rspec-puppet. gem 'rspec', "2.0.0", :require => false I could not get rspec-puppet to pull down rspec 2.0.0 any other way, no idea why it happened here. |
|
Closing and reopening to trigger a new build ... no luck all failed again |
|
That's annoying, I should revisit my PR where I updated some gems and travis config - might fix this as well. |
|
Can you rebase and see if that fixes the tests? |
…in files for type url fixed sensu#385
|
Done. I did have to fix a trailing comma for ruby 1.8.7 rspec after all! |
fixed 385, add owner group sensu:sensu to plugins dir and plugins files
|
Thanks! |
ensure sensu:senu is owner of plugins_dir for type directory and plugin files for type url fixed #385