Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require on apt::update for puppetlabs-apt 2.x #424

Merged
merged 1 commit into from
Sep 24, 2015

Conversation

br0ch0n
Copy link
Contributor

@br0ch0n br0ch0n commented Sep 14, 2015

This problem doesn't always happen. I'm unable to reproduce when
just declaring class {'sensu':} by itself. However, it does seem
to happen when declared in a profile with other classes that use
puppetlabs-apt. My best guess is that once one of the other
classes triggers an apt-get update, another one doesn't happen
within the same run. In any case, the official puppetlabs-apt
docs now state that one's package resource must have an explicit
dependency on class apt::update if you expect things to work in one
run:
https://github.com/puppetlabs/puppetlabs-apt#adding-new-sources-or-ppas

This problem doesn't always happen.  I'm unable to reproduce when
just declaring class {'sensu':} by itself.  However, it does seem
to happen when declared in a profile with other classes that use
puppetlabs-apt.  My best guess is that once one of the other
classes triggers an apt-get update, another one doesn't happen
within the same run.  In any case, the official puppetlabs-apt
docs now state that one's package resource must have an explicit
dependency on class apt::update if you expect things to work in one
run:
https://github.com/puppetlabs/puppetlabs-apt#adding-new-sources-or-ppas

Change-Id: I14ff923ec87cc45f4e845d043b4bf7fca7e11c00
@Pryz
Copy link
Contributor

Pryz commented Sep 14, 2015

Same issue here with puppetlabs-apt 2.1.1 !

This PR works for me ! Thanks :)

@jlambert121
Copy link
Contributor

This whole apt 2.0 stuff is annoying, bet this breaks 1.x versions. I'm thinking with a sensu 2.0 module maybe we'll update the deps to be apt 2.0 as well. Thoughts from those who use apt?

@br0ch0n
Copy link
Contributor Author

br0ch0n commented Sep 23, 2015

There's already been a dependency on puppetlabs-apt 2.0 since 5469295 happened (the "include" param kills puppetlabs-apt 1.x...just confirmed). My change just requires a class that's been defined since at least puppetlabs-apt 1.5, so it probably wouldn't break anything. However, due to the above it doesn't matter anyway. Requiring 2.x is the only way forward unless the referenced commit (and the subsequent one which added the enterprise repo) is altered somehow to add backwards compatibility.

@jlambert121
Copy link
Contributor

I thought we'd jumped back to 1.8.x to make it easier for people to migrate, but that is incorrect - thanks for the response.

jlambert121 added a commit that referenced this pull request Sep 24, 2015
Add require on apt::update for puppetlabs-apt 2.x
@jlambert121 jlambert121 merged commit 3c209d6 into sensu:master Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants