update client config to use socket hash #443
Conversation
|
Thanks! What versions of sensu support the socket hash? |
|
@jlambert121 I think since 0.17, going by the documentation - https://sensuapp.org/docs/0.17/clients has it whereas https://sensuapp.org/docs/0.16/clients does not. Cheers, |
|
Long enough ago then, thanks. Just wanted to make sure it wasn't a brand new feature. |
update client config to use socket hash
|
|
||
| def is_to_s(hash = @is) | ||
| hash.keys.sort.map {|key| "#{key} => #{hash[key]}"}.join(", ") | ||
| end |
There was a problem hiding this comment.
This breaks the puppet run for everyone updating from an old puppet module. Because the "is" variable old doesn't exist and defaultto only works with new resources. Is there a reason why just using the default to_s function of the hash isn't enough?
For example when upgrading to this commit running puppet get this error:
Error: Could not convert change 'socket' to string: undefined methodkeys' for nil:NilClass `
When I change is_to_s to just return hash it then updates cleanly with following log line
Notice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[fqdn]/socket: socket changed '' to {'bind' => '127.0.0.1', 'port' => '3030'}
Actually, I'm pretty sure your is_to_s and should_to_s produces the same formatted input so they are not needed at all.
|
Fix pending in #457 |
Use a socket hash of bind address and port in the sensu_client_config provider.