Fixing regression bug. #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When people are updating from old puppet module the socket is '',
which crashes puppet when it tries to #keys method in the is_to_s
method. Additionally, I think the default change message is good
enough.
Here is how it looks now when upgrading from old puppet module:
`Notice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[fqdn]/socket: socket changed '' to '{"bind"=>"128.0.0.1", "port"=>3030}'`
Here is how it will look when changing:
`Notice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[fqdn]/socket:
socket changed {"bind"=>"1.1.1.1", "port"=3030} to '{"bind"=>"128.0.0.1", "port"=>3030}'`
|
Referencing #447 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When people are updating from old puppet module the socket is '',
which crashes puppet when it tries to #keys method in the is_to_s
method. Additionally, I think the default change message is good
enough.
Here is how it looks now when upgrading from old puppet module:
Notice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[fqdn]/socket: socket changed '' to '{"bind"=>"128.0.0.1", "port"=>3030}'Here is how it will look when changing:
Notice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[fqdn]/socket: socket changed {"bind"=>"1.1.1.1", "port"=3030} to '{"bind"=>"128.0.0.1", "port"=>3030}'