Redaction support #466
Merged
Redaction support #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @jamtur01 or @jlambert121 ? |
|
I've never used redact because I couldn't find good documentation on it. :) It does seem like |
|
I'd like to get this merged as we rely on the mainline sensu module for this. We can add defaults later. ping @jlambert121 |
|
ping again @jamtur01 or @jlambert121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for password redaction which is part of the sensu-core and has been since the early days.
I've also added a README to make use of it, as this isn't well documented.
I've set the value to undef for the time being but I think it could be debated that we should set "password" as the default value.
Any thoughts or feedback is very welcome.