[enterprise dashboard] move package resource inside conditional #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change avoids defining the package resource when the enterprise_dashboard parameter is false. I believe this is desireable because it mirrors the behavior of the enterprise package manifest, making it possible to include this module in another module which manages the sensu-enterprise-dashboard package itself.
|
Looks much better as well 👍 |
|
@jaxxstorm any reason we ought to hold off on merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids defining the package resource when the enterprise_dashboard parameter is false.
I believe this is desirable because it mirrors the behavior of the enterprise package manifest, making it possible to include this module in another module which manages the sensu-enterprise-dashboard package itself.
cc @dhgwilliam as he committed the original implementation