use constant SENSU_CHECK_PROPERTIES instead of hardcoded check_args in sensu_check provider #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ttarczynski can you rebase this so the tests pass? |
ttarczynski
force-pushed
the
sensu_check_refactor
branch
from
d87b303
to
ed0aefe
Compare
|
@jaxxstorm I've just rebased, but the tests on Ruby 1.8.7 fails again (another gem dependency is broken). |
Merged
ttarczynski
force-pushed
the
sensu_check_refactor
branch
from
ed0aefe
to
b331c2c
Compare
|
@jaxxstorm this PR is now rebased and ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows the discussion in #535
And it uses a pattern similar to this: