Use default redact #580
Merged
Use default redact #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Nov 14, 2016
Project: openstack/tripleo-heat-templates 8f9b77ada85118f8f75346ce3eb35f7888b7d6b0 Use default Sensu redact By default sensu-puppet is overring default list of varibles which should be redacted. This patch enables to configure redact list and uses default value given by [1]. This patch also serves as a workaround until [2] is merged in the module itself (or in case it won't get merged). [1] https://sensuapp.org/docs/0.24/reference/clients.html [2] sensu/sensu-puppet#580 Closes-Bug: #1641080 Closes-Bug: rhbz#1392473 Change-Id: I21201f734d2fbf5f571091603126cf11cfdd8c40
openstack-gerrit
pushed a commit
to openstack-archive/tripleo-heat-templates
that referenced
this pull request
Nov 14, 2016
By default sensu-puppet is overring default list of varibles which should be redacted. This patch enables to configure redact list and uses default value given by [1]. This patch also serves as a workaround until [2] is merged in the module itself (or in case it won't get merged). [1] https://sensuapp.org/docs/0.24/reference/clients.html [2] sensu/sensu-puppet#580 Closes-Bug: #1641080 Closes-Bug: rhbz#1392473 Change-Id: I21201f734d2fbf5f571091603126cf11cfdd8c40
openstack-gerrit
pushed a commit
to openstack-archive/tripleo-heat-templates
that referenced
this pull request
Nov 18, 2016
By default sensu-puppet is overring default list of varibles which should be redacted. This patch enables to configure redact list and uses default value given by [1]. This patch also serves as a workaround until [2] is merged in the module itself (or in case it won't get merged). [1] https://sensuapp.org/docs/0.24/reference/clients.html [2] sensu/sensu-puppet#580 Closes-Bug: #1641080 Closes-Bug: rhbz#1392473 Change-Id: I21201f734d2fbf5f571091603126cf11cfdd8c40 (cherry picked from commit c921b15)
|
Perhaps it's better to set this to |
|
Sorry, this fell off my radar. Yes, you are probably right. Avoiding explicit configuration will achieve the default value too. Ok, will change the PR. |
Module should not use different default value than the service is actually using. This patch changes to default redact value according to [1] [1] https://sensuapp.org/docs/0.24/reference/clients.html
hardys
pushed a commit
to hardys/tripleo-heat-templates
that referenced
this pull request
Dec 2, 2016
By default sensu-puppet is overring default list of varibles which should be redacted. This patch enables to configure redact list and uses default value given by [1]. This patch also serves as a workaround until [2] is merged in the module itself (or in case it won't get merged). [1] https://sensuapp.org/docs/0.24/reference/clients.html [2] sensu/sensu-puppet#580 Closes-Bug: #1641080 Closes-Bug: rhbz#1392473 Change-Id: I21201f734d2fbf5f571091603126cf11cfdd8c40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module should not use different default value than the service
is actually using. This patch changes to default redact value
according to [1]
[1] https://sensuapp.org/docs/0.24/reference/clients.html