-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-host Rabbitmq config #581
Add support for multi-host Rabbitmq config #581
Conversation
| @@ -154,6 +154,10 @@ | |||
| # Integer. The integer value for the RabbitMQ prefetch attribute | |||
| # Default: 1 | |||
| # | |||
| # [*rabbitmq_cluster*] | |||
| # Array. Rabbitmq Cluster configuration and connection information for one or more Cluster | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better described as "Array of hashes," similar to other parameters described as "Array of strings." In the interests of disambiguation, redis_sentinels parameter description probably needs the same change.
| "Service[sensu-api]", | ||
| 'Service[sensu-server]', | ||
| 'Service[sensu-client]', | ||
| 'Service[sensu-api]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to (conditionally?) include Service[sensu-enterprise] here as well?
|
I have noticed that with repeated runs, the cluster is considered to be changed every time, even though I haven't made any changes to that portion of the manifest: |
and delete prefetch default unit test which fails because we have removed the default from the manifest, but left it in the type... in other words, the catalog will not contain the default but it will be flushed correctly to disk
converting any value to_i fails on Symbols
|
Amazing work! Great team effort and sincere thanks to @whermann @cwjohnston @dhgwilliam 👍 |
cluster config to be passed as array of hashes
puppet 3 doing something weird with passing the data around, improved munging may have fixed this or we may have found a weird edge case where an array that contains a single hash
[{:k => :v}]gets converted in to an array of arrays[[:k, :v]], but if it contains more than one hash[{:k => :v}, {:k => :v}], it gets passed around correctly?