Fix for enabling strict_variables #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiii
approved these changes
Dec 9, 2016
tomhaynes
approved these changes
Dec 9, 2016
|
@calebhailey - any chance we can get a merge here? It's a really small change to address failures when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This missing variable is causing failures in our spec tests, since we've recently enabled
strict_variables- https://docs.puppet.com/puppet/latest/lang_variables.html#unassigned-variables-and-strict-modeThe change ensures the variable is explicitly set to
undefif thesourceparameter is not set.This will have no negative affect on existing implementations.