Remove sensu check property with absent #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'ts a work in progress, I'll try to add some test coverage for 'absent' values. |
- generate setters and getters for sensu_check properties - added :absent handling in sensu_check type - added rspec test for setting sensu_check params to absent
ttarczynski
force-pushed
the
remove_sensu_check_property_with_absent
branch
from
0793028
to
094e3d6
Compare
|
@jaxxstorm I think this is now ready for merge. I've added a simple rspec test in sensu_check_spec.rb. This PR only adds |
ttarczynski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to remove a check property by setting it's value to
'absent'.I've applied the same logic as in #565 (subdue param only) for all params.
This follows the same logic as puppet type
yumrepo:property => undef– no changes are madeproperty => 'absent'– property is removed from json fileI've based this on puppet type
yumrepoimplementation:This fixes #601, fixes #535