Disable user creation on osfamily = windows by default #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdenneen
changed the title
|
I understand that the change here is motivated by factors described in #586 (comment). @jaxxstorm do you have any concerns about this from a SemVer perspective? I'm not sure if this change would require a major version bump, or what the plans are for the next release. |
|
I've been trying to track major versions with sensu versions, I think we can probably get away with doing a minor bump here as long as we make it clear what's happened in the changelog. |
Until better user management for windows installs can be added this is to prevent attempting to create user/group on windows platform regardless of the manage_user parameter. Fixes issue sensu#617 * NOTE: This would have been better as a case statement in a params.pp class but since that isn't implemented this is a crude workaround for the time being. This is also the default requirement for PR sensu#588
cdenneen
force-pushed
the
windows_manage_user
branch
from
11985d1
to
bdfb721
Compare
|
@dzeleski I take it from your comment in #617 that you're 👍 on this change? If so I think we can merge it. |
|
@cwjohnston In my lab, running on about 30 systems. I try not to run things that are not in the release branch in prod. No issues thus far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #617