Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some lint issues and test spec warnings #640

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Fix some lint issues and test spec warnings #640

merged 1 commit into from
Apr 19, 2017

Conversation

cryptk
Copy link

@cryptk cryptk commented Apr 18, 2017

EDIT: It's a slow day for me today... I went ahead and added documentation to the enterprise modules that were missing it. There should be no lint issues with this PR, squashed it down into the original commit.

Our automated test system was not happy about some of the lint issues (which were also detected by your lint tests as well) so I fixed those up.

While running the test suite I also noticed a couple of warnings about ensure being redefined in the sensu_client_spec.rb file so I cleaned that up as well.

For clarity, here are the lint issues that this fixes:

manifests/enterprise/dashboard/api.pp:1:documentation:WARNING:defined type not documented
manifests/enterprise/dashboard/api.pp:14:relative_classname_inclusion:WARNING:class included by relative name
manifests/enterprise/dashboard/config.pp:1:documentation:WARNING:class not documented
manifests/enterprise/service.pp:1:documentation:WARNING:class not documented
manifests/package.pp:165:variable_scope:WARNING:top-scope variable being used without an explicit namespace
manifests/package.pp:179:variable_scope:WARNING:top-scope variable being used without an explicit namespace
tests/sensu-server-cluster.pp:3:arrow_alignment:WARNING:indentation of => is not properly aligned
tests/sensu-server-cluster.pp:4:arrow_alignment:WARNING:indentation of => is not properly aligned
tests/sensu-server-cluster.pp:5:arrow_alignment:WARNING:indentation of => is not properly aligned
tests/sensu-server-cluster.pp:6:arrow_alignment:WARNING:indentation of => is not properly aligned
tests/sensu-server-cluster.pp:7:arrow_alignment:WARNING:indentation of => is not properly aligned
tests/sensu-server-cluster.pp:8:arrow_alignment:WARNING:indentation of => is not properly aligned
tests/sensu-server-cluster.pp:9:arrow_alignment:WARNING:indentation of => is not properly aligned
tests/sensu-server-cluster.pp:10:arrow_alignment:WARNING:indentation of => is not properly aligned
tests/sensu-server-cluster.pp:31:trailing_comma:WARNING:missing trailing comma after last element
tests/sensu-server-cluster.pp:30:trailing_comma:WARNING:missing trailing comma after last element

And here are the two test warnings:

/home/cryptk/Documents/sourcecode/sensu/spec/classes/sensu_client_spec.rb:13: warning: key :ensure is duplicated and overwritten on line 18
/home/cryptk/Documents/sourcecode/sensu/spec/classes/sensu_client_spec.rb:37: warning: key :ensure is duplicated and overwritten on line 43

@cwjohnston
Copy link
Contributor

@cryptk thanks for the PR! this all looks reasonable to me.

@cwjohnston cwjohnston merged commit ed9bf2a into sensu:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants