Update version string validation to allow for redhat platform suffix #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwjohnston
force-pushed
the
fix/version-string-validation
branch
from
000c60f
to
79e1031
Compare
|
Tested on Server 2012R2, RHEL 6 and 7 with no issues. Version string used: |
|
Per #577 (comment) we're OK with dropping Puppet 3.8 in the next release, so I'm going to go ahead and merge this. I suspect it still works with Puppet 3.8 anyway. |
|
Thank you @cwjohnston |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RHEL-like platforms, version strings for Sensu 0.27 and later include a
.elXsuffix (whereXrepresents the OS major version), which the current validation regex will not permit. This change seeks to loosen the validation regex to allow for this version string suffix.Closes #641