-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to write arbitrary JSON to a file #671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robbyt could you please have a look at these spec tests for the function |
|
@ghoneycutt please apply this patch: diff --git a/spec/functions/sensu_sorted_json_spec.rb b/spec/functions/sensu_sorted_json_spec.rb
index df486c5..8b5e1d9 100644
--- a/spec/functions/sensu_sorted_json_spec.rb
+++ b/spec/functions/sensu_sorted_json_spec.rb
@@ -1,11 +1,18 @@
require 'spec_helper'
-describe 'sensu_write_json' do
+describe 'sensu_sorted_json' do
+ it { is_expected.not_to eq(nil) }
+
describe 'should error when expected' do
it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError, /0 for 1, 2 or 3/) }
it { is_expected.to run.with_params(1,2,3,4).and_raise_error(Puppet::ParseError, /4 for 1, 2 or 3/) }
end
- valid_hash = {"bind_addr"=>"192.168.34.56","client_addr"=>"127.0.0.1","ports"=>{"http"=>-1,"https"=>8500,"rpc"=>8567},"start_join"=>["192.168.34.60","192.168.34.61","192.168.34.62"]}
+ valid_hash = {
+ "bind_addr"=>"192.168.34.56",
+ "client_addr"=>"127.0.0.1",
+ "ports"=>{"http"=>-1,"https"=>8500,"rpc"=>8567},
+ "start_join"=>["192.168.34.60","192.168.34.61","192.168.34.62"],
+ }
valid_pretty_hash = <<-END.gsub(/^\s+\|/, '')
|{
@@ -26,7 +33,7 @@ describe 'sensu_write_json' do
describe 'should return correct results' do
it 'should run with valid hash' do
- should run.with_params(valid_hash).and_return(valid_pretty_hash)
+ is_expected.to run.with_params(valid_hash, true, 4).and_return(valid_pretty_hash)
end
end
end
|
|
@robbyt Thanks for the patch |
Add sensu::write_json defined resource type, used for writing custom config files. Which makes use of the new sensu_sorted_json() function for turning a hash into sorted JSON.
These versions have ruby < 2.1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.