Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working on PR501 #703

Merged
merged 3 commits into from
Jul 6, 2017
Merged

Working on PR501 #703

merged 3 commits into from
Jul 6, 2017

Conversation

Phil-Friderici
Copy link
Collaborator

Phil-Friderici and others added 2 commits July 3, 2017 18:36
@Phil-Friderici
Add tests for $plugins
ef562cf
@r0b0tAnthony @Phil-Friderici
Plugins should be hash and use create_resources
b2649e6 
The plugins variable should be hash to allow multiple types of plugins to be
installed and allow the install directory to be chose as this defaults to
/etc/sensu which breaks windows support. This requires an addition of
plugins_defaults to provide an easy way to provide defaults to override
sensu::plugins variables such as install_path easily.
@Phil-Friderici Phil-Friderici mentioned this pull request Jul 3, 2017
Closed
@ghoneycutt
Copy link
Collaborator

@Phil-Friderici Looks good. Could you please update the README to show that hashes are also allowed. BTW, when referring to an issue, use (GH-###) in the commit where ### is the issue number (GH is for GitHub).

You can see previous commits here - https://github.com/sensu/sensu-puppet/commits/master

@Phil-Friderici
Copy link
Collaborator Author

@ghoneycutt README is updated. I didn't found a matching issue for this new feature. Did I miss it ?

@Phil-Friderici Phil-Friderici mentioned this pull request Jul 4, 2017
Closed
@Phil-Friderici
Copy link
Collaborator Author

Maybe we shouldn't propagate the usage of strings for plugins in the docs explicitly?
I guess on the long run arrays and hashes should keep supported only.

@ghoneycutt ghoneycutt merged commit 1349232 into sensu:master Jul 6, 2017
@ghoneycutt
Copy link
Collaborator

Released in v2.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Phil-Friderici @ghoneycutt @agoddard @r0b0tAnthony