(#638) Enable multiple Sensu Enterprise Dashboard API endpoints #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 6, 2017 11:32
it turns out that 'name' isn't necessarily unique and puppet requires that a param named 'name' must be the namevar (which must be unique)
also add some acceptance tests
|
Awesome work! |
|
They have to be exported.
|
|
Looks like style issues with the new test manifest |
|
Dooh, fixing now.
|
Without this patch it is not possible to manage multiple sensu::enterprise::dashboard::api resources in the same datacenter because the resources conflict over the namevar. This patchset addresses the problem by changing the namevar to the `host` and establishing the `datacenter` attribute. An example of how to exercise this behavior is located in tests/sensu-enterprise-dashboard-multi-api.pp resolves sensu#638 closes sensu#651 closes sensu#584
jeffmccune
force-pushed
the
638_fix_dashboard_api_config_type
branch
from
3233495
to
d834e53
Compare
|
Fixed, passing locally. Should be good.
|
|
Released in v2.14.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch it is not possible to manage multiple
sensu::enterprise::dashboard::api resources in the same datacenter because
the resources conflict over the namevar. This patchset addresses the
problem by changing the namevar to the
hostand establishing thedatacenterattribute.An example of how to exercise this behavior is located in
tests/sensu-enterprise-dashboard-multi-api.pp
resolves #638
closes #651
closes #584