(#717) Remove rabbitmq_reconnect_on_error #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmccune
force-pushed
the
717_fix_rabbitmq_reconnect_on_error
branch
from
40eb658
to
ff41928
Compare
ghoneycutt
approved these changes
Jul 8, 2017
|
@jeffmccune looks good but needs a rebase to fix the merge conflict. |
Added transport.pp, modified init.pp with new transport vars, edited redis config.pp to be deployed to clients if transport is redis.
jeffmccune
force-pushed
the
717_fix_rabbitmq_reconnect_on_error
branch
from
ff41928
to
bd07f5c
Compare
|
Rebased. |
|
Released in v2.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #717, the configuration setting for reconnecting on error lives in
the transport configuration, not the rabbitmq configuration. This patch
removes the property and class parameter configuring the rabbitmq specific
behavior.
Resolves #717
Closes #595