(#735) Fix sensu-server-enterprise Vagrant VM #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
requested changes
Jul 12, 2017
| @@ -1,5 +1,14 @@ | |||
| node 'sensu-server' { | |||
|
|
|||
| Ini_setting { | |||
There was a problem hiding this comment.
please add that curl command to test in the comments here.
Vagrantfile
Outdated
| @@ -25,7 +25,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config| | |||
| config.vm.define "sensu-server", primary: true, autostart: true do |server| | |||
| server.vm.box = "centos/7" | |||
| server.vm.hostname = 'sensu-server.example.com' | |||
| server.vm.network :private_network, ip: "192.168.56.10" | |||
| server.vm.network :private_network, ip: ENV['VAGRANT_SENSU_SERVER_IP'] || '192.168.56.10' | |||
There was a problem hiding this comment.
Could you please document this in the Vagrantfile
There was a problem hiding this comment.
Sure thing, documentation added to the top of the Vagrantfile. I also renamed the variables and consolidated to ENV['ALTERNATE_IP'] for clarity.
jeffmccune
force-pushed
the
735_vagrant_ports
branch
from
11cb74d
to
17ebd7d
Compare
Without this patch the sensu-enterprise server is quickly crashing with a JVM
out of memory error when started inside the sensu-server-enterprise VM.
This patch addresses the problem by bumping up the allocated RAM for the VM
from 512m to 768m while also bringing down the JVM heap size from 2GB to 256m.
The API has been tested with the following commands, with no other VM's
running:
vagrant up sensu-server-enterprise
curl -s http://admin:secret@127.0.0.1:4567/clients \
| jq -r 'map(.name | split(".") | .[0]) | sort | .[]'
Resolves sensu#735
jeffmccune
force-pushed
the
735_vagrant_ports
branch
from
17ebd7d
to
d6715ec
Compare
ghoneycutt
approved these changes
Jul 13, 2017
|
Released in v2.22.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the sensu-enterprise server is quickly crashing with a JVM
out of memory error when started inside the sensu-server-enterprise VM.
This patch addresses the problem by bumping up the allocated RAM for the VM
from 512m to 768m while also bringing down the JVM heap size from 2GB to 256m.
The API has been tested with the following commands, with no other VM's
running:
Resolves #735