(#727) Add sensu::spawn_limit class parameter #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
requested changes
Jul 13, 2017
| # clients. See [#727](https://github.com/sensu/sensu-puppet/issues/727) for | ||
| # more information. The default is undefined, which does not manage | ||
| # `/etc/sensu/conf.d/spawn.json` | ||
| # Default: undef |
There was a problem hiding this comment.
the commit reads a default of 12 though this is undef.
There was a problem hiding this comment.
Updated the commit message to read:
If unset, the module behavior defers to the default behavior of Sensu which uses an effective spawn limit of 12 in version 0.29.0.
Without this patch the Sensu spawn limit setting cannot easily be configured by this module. This patch addresses the problem by adding a sensu::spawn_limit class parameter. If unset, the module behavior defers to the default behavior of Sensu which uses an effective spawn limit of 12 in version 0.29.0. Resolves sensu#727
jeffmccune
force-pushed
the
727_spawn_limit
branch
from
01bde14
to
8224cc3
Compare
ghoneycutt
approved these changes
Jul 13, 2017
|
Released in v2.24.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the Sensu spawn limit setting cannot easily be configured by
this module. This patch addresses the problem by adding a sensu::spawn_limit
class parameter. If unset, the parameter defaults to the behavior of Sensu
which is to have a limit of 12 in version 0.29.0.
Resolves #727