Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PR-528) working with kali-hernandez #745

Merged
merged 2 commits into from
Jul 14, 2017
Merged

(PR-528) working with kali-hernandez #745

merged 2 commits into from
Jul 14, 2017

Conversation

Phil-Friderici
Copy link
Collaborator

@Phil-Friderici Phil-Friderici commented Jul 14, 2017 •
edited
Loading

  • Rebased against master
  • Update docs
  • Add test for new functionality

@Phil-Friderici Phil-Friderici mentioned this pull request Jul 14, 2017
Closed
kali-hernandez and others added 2 commits July 14, 2017 08:14
@kali-hernandez @Phil-Friderici
Allow for undefined command param on ensure => absent
a0d11e2 
Before this change, declaring a sensu::check to be absent with no command would fail:

```
  sensu::check {
    'check_system_raid':
      ensure => 'absent';
  }
```
The above would cause:
```
Error: Could not retrieve catalog from remote server:
Error 400 on SERVER:
Evaluation Error:
Error while evaluating a Resource Statement, Sensu::Check[check_system_raid]:
expects a value for parameter 'command' at [..] on node [...]
```

This commit allows for undefined `command` parameter which would be validated only if ensure is present (default), raising a specific error if command is missing.

Conflicts:
	manifests/check.pp
@Phil-Friderici
(PR-528) Allow for undefined command param on ensure => absent
05a7679 
* Rebase against master
* Update docs
* Add tests for new functionality
@ghoneycutt ghoneycutt self-requested a review July 14, 2017 13:15
@ghoneycutt ghoneycutt merged commit 2289fe2 into sensu:master Jul 14, 2017
@ghoneycutt
Copy link
Collaborator

Released in v2.25.0

@Phil-Friderici Phil-Friderici deleted the PR-528 branch September 7, 2017 10:18
ghoneycutt added a commit that referenced this pull request Sep 18, 2017
@ghoneycutt
Merge pull request #814 from Phil-Friderici/GH-745
0c0510b 
Add vagrant tests for add/remove checks with sensu::check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghoneycutt ghoneycutt ghoneycutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Phil-Friderici @ghoneycutt @agoddard @kali-hernandez