(#550) Add sensu client de-registration #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmccune
force-pushed
the
550_deregistration
branch
2 times, most recently
from
ed4bd06
to
9d22d3a
Compare
|
We should have some more spec tests for this. |
ghoneycutt
requested changes
Jul 14, 2017
jeffmccune
force-pushed
the
550_deregistration
branch
from
9d22d3a
to
ee3d500
Compare
@ghoneycutt Added some additional spec tests and exercised the change with vagrant in quite a few different ways. I'm confident and satisfied at this point. |
|
This should be good to go for review / merge. |
jeffmccune
force-pushed
the
550_deregistration
branch
from
ee3d500
to
ab09096
Compare
|
Rebased. |
Lots of failing tests... Making another pass at the rebase now. Should be quick. |
jeffmccune
force-pushed
the
550_deregistration
branch
from
ab09096
to
4862f26
Compare
Without this patch the sensu client does not support the deregister and deregistration attributes. These attributes are documented at [deregistration attributes](https://sensuapp.org/docs/latest/reference/clients#deregistration-attributes) This patch adds the `sensu::client_deregister` and `sensu::client_deregistration` class parameters which flow through to the sensu_client_config type and provider. This patch also refactors the sensu_client_config type and provider to operate the same way as the sensu_check type and provider. Specifically, the JSON provider dynamically introspects the set of properties from the type and creates getter and setter methods to output the JSON. Custom attributes are enhanced, if `client_custom = absent` then all custom attributes in the client configuration are removed. Otherwise, the custom attributes are merged on top of any existing custom attributes. When the client config is flushed to /etc/sensu/conf.d/client.json the top level set of keys are sorted. This isn't terribly useful as there is usually just one key, `{"client":{}}`. The value of the client attribute is also sorted, making the output more useful and human readable. Resolves sensu#550
jeffmccune
force-pushed
the
550_deregistration
branch
from
4862f26
to
4a0a33f
Compare
|
OK, rebased for real |
ghoneycutt
approved these changes
Jul 19, 2017
|
Released in v2.27.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the sensu client does not support the deregister and
deregistration attributes. These attributes are documented at deregistration
attributes
This patch adds the
sensu::client_deregisterandsensu::client_deregistrationclass parameters which flow through to thesensu_client_config type and provider.
This patch also refactors the sensu_client_config type and provider to operate
the same way as the sensu_check type and provider. Specifically, the JSON
provider dynamically introspects the set of properties from the type and
creates getter and setter methods to output the JSON. Custom attributes are
enhanced, if
client_custom = absentthen all custom attributes in the clientconfiguration are removed. Otherwise, the custom attributes are merged on top
of any existing custom attributes.
Resolves #550