Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet strings 4 all #757 #792

Merged
merged 1 commit into from
Aug 14, 2017
Merged

Puppet strings 4 all #757 #792

merged 1 commit into from
Aug 14, 2017

Conversation

alvagante
Copy link
Collaborator

No description provided.

@alvagante alvagante changed the title Puppet strings 4 all #757 WIP: Puppet strings 4 all #757 Aug 9, 2017
@@ -1,3 +1,14 @@
# @!puppet.type.param name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you doing the rest of the types/providers in another pass?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghoneycutt yes, but actually I was wondering if all the current types, and relevant providers, are going to remain as is or some of them are will be replaced by the works @jeffmccune is doing in #785 will affect some of the current ones, and their params. If so I wonder if it makes sense to prepare docs for types that are going to change soon.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Don't bother with the ones that are changing and we'll make another pass after the dust settles.

Mass conversion of manifests

Fixed puppet-trings warnings

Minors

Minor

Added params lists to types

Removed redundant params list in types (for puppet strings)

More strings edits

Fixed spec tests

Fixed some of the added data types

Fix heap_size validation
@alvagante alvagante changed the title WIP: Puppet strings 4 all #757 Puppet strings 4 all #757 Aug 14, 2017
@alvagante
Copy link
Collaborator Author

@ghoneycutt This is ready for merging, from my point of view. I've added Puppet 4 params validations in a pair of classes where it was missing, in order to have valid entries in puppet strings and to align those classes to the others.

@ghoneycutt ghoneycutt merged commit bc5f043 into sensu:master Aug 14, 2017
@ghoneycutt
Copy link
Collaborator

Thanks @alvagante

Released in v2.31.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants