Force array for some sense::check params #801

[alvagante]

Pull Request Checklist

Changed sensu::check define and relevant spec tests.

Description

This commit converts strings to arrays with a single element, when a String is used for the handlers, subscribers and aggregates parameters in sensu::check

This PR replaces #803

Related Issue

Fixes #801

Motivation and Context

Syntax errors on check files when using strings on the given params.

How Has This Been Tested?

Tested on sensu-server vagrant vm and spec tests.

General

• Update README.md with any necessary configuration snippets

• New parameters are documented

• New parameters have tests

• Tests pass - bundle exec rake validate lint spec

[alvagante]

@ghoneycutt this is finally a clean PR on #801 .
But I think we may reconsider the opportunity to throw a deprecation notice.
I see in the README (which would need update if we keep the current code) examples like this:

  sensu::check { 'check_ntp':
    command     => 'PATH=$PATH:/usr/lib/nagios/plugins check_ntp_time -H pool.ntp.org -w 30 -c 60',
    handlers    => 'default',
    subscribers => 'sensu-test'
  }

which means that a lot of existing code has strings where we expect an array.
I would just remove the deprecation notice, and convert string to array when needed.
That's probably the original intention.

[ghoneycutt]

@alvagante Good eye, I agree. Let's just silently convert to array for our implementation.

[alvagante]

@ghoneycutt ready for merge

[ghoneycutt]

Thanks @alvagante

Released in v2.33.1