Added http_socket param to client config #776

[alvagante]

Pull Request Checklist

Added parameter http_socket to client config.

Description

Added parameter to main class, and then reference to it in sunse::client is passwd to the sensu_client_config type used the new json write approach.

Related Issue

Fixes #776

Motivation and Context

How Has This Been Tested?

Tested os samples vms and spec.

General

• Update README.md with any necessary configuration snippets

• New parameters are documented

• New parameters have tests

• Tests pass - bundle exec rake validate lint spec

[ghoneycutt]

Could you add a test that reads a fixture file and sees that the json created matches like what is done in spec/defines/sensu_check_spec.rb.

[alvagante]

@ghoneycutt sorry, I spent 2 hours in trying to make it and I didn't succeed, so I prefer to raise hand before engaging further efforts.
First, I'm not 100% sure on where you want the test, on the sensu_client_config type (here) or on the sensu::client class.
I've tried with both , but haven't found any usable resource to compare directly to the fixturejson file, in spec/classes/sensu_client_spec.rb (where I could use an approach similar to the spec/defines/sensu_check_spec.rb) I can only tests parameters passed to the the sensu_client_config type, and this is already done.
In spec/unit/sensu_client_config_spec.rb I don't know what to compare with the content of the fixture file, I can test single params, but haven't found a way to do something based on the whole file.
IMHO current tests, and tested implementation on real VM, should be enough, considering that also for other params of sensu_client_config we don't tests against fixture json files.
But I leave to you the final word here and, eventually, the support to finalise the tests.

[ghoneycutt]

Thanks! Released in v2.34.0