Added hooks support #836

[alvagante]

Pull Request Checklist

Introduces support for hooks

Description

Commit addes the hooks parameter to the sensu::check define

Related Issue

Fixes #836

Motivation and Context

How Has This Been Tested?

Spec tested.
Integration test on PSICK setup.

General

• Update README.md with any necessary configuration snippets

• New parameters are documented

• New parameters have tests

• Tests pass - bundle exec rake validate lint spec

[ghoneycutt]

Can you please add a test for us to verify this works in vagrant.

[ghoneycutt]

@dzeleski Could you please test that this works for you before we release it. Thanks!!!

[dzeleski]

Yep will do, working on that now. Might have to get back to you first thing in the morning though as I have to leave around 6pm EST tonight.

[dzeleski]

Inputs and outputs below, let me know if you need anything else tested. @ghoneycutt

Input:

sensu::check{ 'cl-pup-healthcheck-puppet_pemaster':
    command     => '/opt/sensu/embedded/bin/ruby /opt/sensu/embedded/bin/check-puppet-healthcheck.rb',
    handlers    => 'linux_handler',
    interval    => 300,
    subscribers => 'puppet_pemaster',
    standalone  => false,
    occurrences => 1,
    notify      => Service['sensu-enterprise'],
    hooks       => {
      critical => {
        command => 'test command',
        },
    },
  }

Output:

{
    "checks": {
        "cl-pup-healthcheck-puppet_pemaster": {
            "command": "/opt/sensu/embedded/bin/ruby /opt/sensu/embedded/bin/check-puppet-healthcheck.rb",
            "handlers": [
                "linux_handler"
            ],
            "hooks": {
                "critical": {
                    "command": "test command"
                }
            },
            "interval": 300,
            "occurrences": 1,
            "standalone": false,
            "subscribers": [
                "puppet_pemaster"
            ]
        }
    }
}

[alvagante]

@ghoneycutt Added vagrant test manifests and check on the name of the hooks (I didn't realise that only some specific values are accepted) with relevant spec test.
Rebased and ready to merge (if travis won't surprise me).

[ghoneycutt]

Thank you everyone for your help getting this implemented!!

Released in v2.39.0