Added support for MAX_OPEN_FILES environment variable #849 #850
Conversation
| @@ -28,6 +28,8 @@ | |||
| # | |||
| # @param heap_size Value of the HEAP_SIZE environment variable. | |||
| # | |||
| # @param max_open_files Value of the MAX_OPEN_FILES environment variable. | |||
There was a problem hiding this comment.
Why is the parameter added to three different classes?
There was a problem hiding this comment.
I followed the current approach for similar cases, but actually you're right, max_open_files in this case can and should not stay in package.pp. Actually if we split the sensu.erb template used both by /etc/default/sensu and /etc/default/sensu-enterprise we will be able to set ee-only parameters only in enterprise.pp
There was a problem hiding this comment.
Do we need it anywhere except the enterprise class then?
There was a problem hiding this comment.
Actually, we need these params also in init.pp, besides enterprise.pp for how the module is done and tested (all spec tests for the various subclasses, in reality, test on the main class)
There was a problem hiding this comment.
Do we need it in the package class then?
There was a problem hiding this comment.
Parameters used only in puppet enterprise are not needed in packages class.
FYI just pushed with the code to support other sense ee settings like JAVA_OPTS.
Have to properly test on vagrant yet.
These changes anyway, might be obsoleted by what we decide in #851 .
|
@ghoneycutt this should be ready, and even if it might be refactored on the lines on what's under discussion in #852 I'd not wait for it. |
|
Thank you! Released in v2.42.0 |
Pull Request Checklist
Description
Related Issue
Fixes # .
Motivation and Context
How Has This Been Tested?
General
Update
README.mdwith any necessary configuration snippetsNew parameters are documented
New parameters have tests
Tests pass -
bundle exec rake validate lint spec