Macos #863
Macos #863
Conversation
manifests/server/service.pp
Outdated
| @@ -21,7 +21,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| if $::osfamily != 'windows' { | |||
| if $::osfamily !~ /(windows|Darwin)/ { | |||
There was a problem hiding this comment.
instead of a negative regex this should just be
if $::kernel == 'Linux' {
|
@alvagante This is working in vagrant, though needs spec tests added for all the new changes. Could you please have a look. |
|
Needs to be tested with sensu-enterprise |
There was a problem hiding this comment.
I've added various darwin specific spec tests and tested also on sensu enterprise vagrant.
ghoneycutt#3
Note that I didn't reproduce ALL the tests conditions for MacOS but limited to the resources where we actually changed things.
|
@csoleimani can you please test this and let us know how it goes? |
|
yup, will test it with our environment tomorrow |
|
seems to work fine for me 👍 |
|
Thanks @csoleimani and @alvagante for all the hard work to add MacOS support!! |
|
Released in v2.45.0 |
Pull Request Checklist
Add client support for MacOS
Description
Add client support for MacOS
Related Issue
Rebase of Issue #826
Fixes #862
Motivation and Context
Supports another platform
How Has This Been Tested?
General
Update
README.mdwith any necessary configuration snippetsNew parameters are documented (no new params)
New parameters have tests (no new params)
New tests are written
Tested in Vagrant with Sensu Enterprise
csoleimani has signed off on this