Allow gem_install_options on sensu_gem plugins

[statyk]

Pull Request Checklist

Description

Related Issue

Fixes # .

Motivation and Context

How Has This Been Tested?

General

• Update README.md with any necessary configuration snippets

• New parameters are documented

• New parameters have tests

• Tests pass - bundle exec rake validate lint spec

[ghoneycutt]

Looks good. @treydock could you please test our matrix in vagrant and confirm.

[treydock]

@ghoneycutt majority of tests pass. Failures unrelated to this module.

sensu-server                pass
sensu-server-cluster        pass
sensu-server-puppet5        pass
sensu-server-enterprise     pass
el7-client                  pass
el6-client                  pass
ubuntu1604-client           pass
ubuntu1404-client           pass
amazon201703-client         failed - vagrant
win2012r2-client            pass
win2012r2-client-chocolatey failed - unable to install from chocolatey
debian9-client              failed - vagrant
debian8-client              pass
debian7-client              pass
macos-client                failed - vagrant

[ghoneycutt]

@treydock could you please open issues for why the tests failed with Vagrant. I'd like to be sure they are not somehow related before merging this.

[treydock]

@ghoneycutt As mentioned in new issue #891, the failures except chocolatey one are unrelated to this module. The issues are more with the actual vagrant boxes.

Also based on the change in this PR, only tests/sensu-server-proxy-checks.pp uses sensu::plugin and as far as I can tell that manifest is not loaded by any of the vagrant boxes.

[ghoneycutt]

Released in v2.53.0

[cdenneen]

Not sure if related but using 2.52.0 with windows the gem_install_options being set to --source http://artifactory.domain.com/api/rubygems/rubygems yields the following

Execution of 'C:/Program Files/Puppet Labs/Puppet/sys/ruby/bin/gem.bat install --no-rdoc --no-ri sensu-plugin "--source http://artifactory.domain.com/api/rubygems/rubygems"' returned 1: ERROR: While executing gem ... (URI::InvalidURIError) bad URI(is not URI?): ?gems="--source http://artifactory.domain.com/api/rubygems/rubygems" Successfully installed mixlib-cli-1.7.0 Successfully installed sensu-plugin-2.5.0
change from absent to present failed: Execution of 'C:/Program Files/Puppet Labs/Puppet/sys/ruby/bin/gem.bat install --no-rdoc --no-ri sensu-plugin "--source http://artifactory.domain.com/api/rubygems/rubygems"' returned 1: ERROR: While executing gem ... (URI::InvalidURIError) bad URI(is not URI?): ?gems="--source http://artifactory.domain.com/api/rubygems/rubygems" Successfully installed mixlib-cli-1.7.0 Successfully installed sensu-plugin-2.5.0
Source:
/Stage[main]/Sensu::Package/Package[sensu-plugin]/ensure

Will testing 2.53.0 shortly but just in case anyone else seeing these issues...

[cdenneen]

2.53.0 still has same issue above exactly.
Was this only tested with linux? Maybe gem.bat can't take a --source parameter? or the quoting is what's throwing it off? @treydock @ghoneycutt any ideas?

[ghoneycutt]

Thanks @cdenneen for reporting this! Opened Issue #908 to track this.