Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-902) Add client_socket_enabled boolean parameter #905

Merged
merged 1 commit into from
May 21, 2018

Conversation

treydock
Copy link
Collaborator

@treydock treydock commented May 9, 2018

Pull Request Checklist

Description

Add client_socket_enabled parameter that when false will disable the sensu client socket.

Related Issue

Fixes #902 .

Motivation and Context

This change is required to support sensu 1.3.0 to allow disabling the sensu client socket.

How Has This Been Tested?

Unit tests added

General

  • Update README.md with any necessary configuration snippets

  • New parameters are documented

  • New parameters have tests

  • Tests pass - bundle exec rake validate lint spec

@jaredledvina
Copy link
Contributor

jaredledvina commented May 10, 2018

I just caught something in our environment w/ the Client TCP/UDP socket disabled, if you do disable it, but keep deregister_on_stop set to true, it fails because that setting is enabling this: https://github.com/sensu/sensu-build/blob/c227fc99b74cbcf52ec88fe9d1a12ab813b299d6/sensu_configs/init.d/sensu-service#L200-L204

There's also https://docs.sensu.io/sensu-core/1.3/reference/clients/#deregistration-attributes as an alternative to the way deregister_on_stop works which does work w/ the client socket disabled.

Just wanted to throw that out there.

@ghoneycutt
Copy link
Collaborator

@jaredledvina Can you please confirm this patch works for you before we merge?

@jaredledvina
Copy link
Contributor

@ghoneycutt - Absolutely, I'll give it a run through today.

Copy link
Contributor

@jaredledvina jaredledvina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, setting client_socket_enabled to false does disable the local client TCP/UDP socket.

@ghoneycutt ghoneycutt merged commit 8b7ab57 into sensu:master May 21, 2018
@ghoneycutt
Copy link
Collaborator

Released in v2.53.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for disabling the TCP/UDP Socket entirely
3 participants