Dsc (continued) #917
Merged
Dsc (continued) #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
requested changes
Jan 7, 2019
Refactor to use DSC for installing the service * Add new parameter `$windows_service_user` which can be used to run the service as a different user. * Use `dsc_service` resource instead of `exec` to install the service. If `$windows_service_user` isn't set then this will just use the Local System user as normal. * If `$windows_service_user` is set then also use the `dsc_userrightsassignment` resource to grant the "Log on as a service" right to the user and also use the `acl` module to grant permission for the user to access the Sensu install directory. Fixed tests with new Windows modules added spec tests Readded powershell dependency (needed by dsc) Powershll module already installed by dsc, avoid version conflicts
|
Rebased to fix merge conflicts. |
ghoneycutt
approved these changes
Jan 8, 2019
…ll 5+ Reload action in vagrant requires "vagrant plugin install vagrant-reload"
|
Updated PR so tests should be passing now. |
|
Waiting on Travis. Good to merge. |
|
Released in v2.61.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Related Issue
Continuation of #907
Motivation and Context
Same as #907 with updates to Vagrant tests for Windows to have Powershell 5+.
How Has This Been Tested?
Fresh install tested with Vagrant. Also tested by provisioning win2012r2-client box without these changes and then apply changes from this PR and no errors were encountered.
General
Update
README.mdwith any necessary configuration snippetsNew parameters are documented
New parameters have tests
Tests pass -
bundle exec rake validate lint spec