Sensu Redis - Support boolean redis_tls parameter (cont #967)

[treydock]

Pull Request Checklist

Description

Add on to work in #967

Related Issue

Fixes #900 and extends #967 .

Motivation and Context

Ensure redis_tls is a proper boolean property and ensure the provider is checking the symbol value.

How Has This Been Tested?

I modified tests/sensu-server.pp to add redis_tls => true:

[root@sensu-server ~]# puppet apply sensu-server.pp
Notice: Compiled catalog for sensu-server.example.com in environment production in 1.87 seconds
Notice: /Stage[main]/Sensu::Redis::Config/Sensu_redis_config[sensu-server.example.com]/tls: tls changed 'false' to 'true'
Notice: /Stage[main]/Sensu::Api/Service[sensu-api]: Triggered 'refresh' from 2 events
Notice: /Stage[main]/Sensu::Server::Service/Service[sensu-server]: Triggered 'refresh' from 1 events
Notice: Applied catalog in 3.21 seconds

Resulting config:

[root@sensu-server ~]# cat /etc/sensu/conf.d/redis.json
{
  "redis": {
    "port": 6379,
    "host": "127.0.0.1",
    "reconnect_on_error": true,
    "db": 0,
    "auto_reconnect": true,
    "tls": {
    }
  }
}

General

• New parameters are documented

• New parameters have tests

• Tests pass - bundle exec rake validate lint spec

[treydock]

Worth noting testing with tests/sensu-server.pp is not great because once tls support is added to redis.json it breaks sensu-server service since the Vagrant environment doesn't configure Redis for TLS, is my guess.

[ghoneycutt]

If it is false doesn't the provider delete the tls key?

[treydock]

Yes but this just tests the parameter getting passed to sensu_redis_config resource which is either true or false. This doesn't test the provider behavior.

[ghoneycutt]

@jaredledvina Could you please confirm this works for you.

[jaredledvina]

@ghoneycutt - Yep, I'm AFK but will check once I'm back at a computer (probably early AM Tuesday). Thanks!

[jaredledvina]

Alright, sorry for the delay, I applied this branch to our internal version of the module and undid my forked changes. Gave it a run on our Sensu instances and it works like a charm.
And our redis.json file looks solid!

> cat /etc/sensu/conf.d/redis.json
{
  "redis": {
    "port": 6379,
    "host": "SNIP",
    "password": "SNIP",
    "reconnect_on_error": true,
    "db": 0,
    "auto_reconnect": true,
    "tls": {
    }
  }
}

Amazing, thanks so much @treydock and @ghoneycutt !

[ghoneycutt]

Released in v2.54.0