Support Puppet 6 #988
Merged
Support Puppet 6 #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Oct 1, 2018
.travis.yml
Outdated
| env: BEAKER_set="centos-6" BEAKER_PUPPET_COLLECTION=puppet5 | ||
| bundler_args: | ||
| script: bundle exec rake beaker | ||
| - rvm: 2.4.4 |
There was a problem hiding this comment.
puppet6 should use 2.5.1
There was a problem hiding this comment.
That version of RVM only affects beaker outside the container environment so no bearing on Puppet Ruby version since Ruby is installed into container using packages. Still want it to be 2.5.1? I kept consistent with other beaker tests since only interacts with beaker.
There was a problem hiding this comment.
Yeah, because we want the testing environment to match the version we actually use. This is useful so any other ruby tooling used around your Puppet setup can be on the same version.
|
Updated to use ruby 2.5.1 for all Puppet 6 related tests. |
Closed
|
released in v2.55.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Add support for Puppet 6.
Use
filterfunction forcheck_notifybecause unit tests would fail as it seemsdelete_undef_valueswas returning[nil,nil,nil,nil]and not actually filteringUndef.Related Issue
Fixes #983
Motivation and Context
Add support for Puppet 6. Updated logic in acceptance tests setup to be simpler and more like sensu2 so that easy to use different Puppet collection in tests based on environment variables.