Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all Vagrant boxes to use Puppet5 #992

Merged
merged 2 commits into from
Jan 1, 2019

Conversation

treydock
Copy link
Collaborator

Pull Request Checklist

Description

Have all Vagrant boxes use Puppet5.

Related Issue

This is needed for #991 Vagrantfile change to be functional. Also should have likely been a part of #988 when Puppet 4 support was dropped.

Motivation and Context

This module no longer tests against Puppet 4 so stop using Puppet 4 in Vagrant.

How Has This Been Tested?

@treydock
Copy link
Collaborator Author

My vagrant environment is not working at the moment so been difficult to test these changes locally.

@treydock
Copy link
Collaborator Author

Updated PR.

@@ -15,8 +15,7 @@ OSX_VERSION=$(sw_vers | grep -i productversion| awk '{print $2}' | cut -f1,2 -d'
#--------------------------------------------------------------------
# Modifiable variables, please set them via environmental variables.
#--------------------------------------------------------------------
FACTER_PACKAGE_URL=${FACTER_PACKAGE_URL:-"http://downloads.puppetlabs.com/mac/facter-latest.dmg"}
PUPPET_PACKAGE_URL=${PUPPET_PACKAGE_URL:-"http://downloads.puppetlabs.com/mac/$OSX_VERSION/PC1/x86_64/puppet-agent-1.10.4-1.osx$OSX_VERSION.dmg"}
PUPPET_PACKAGE_URL=${PUPPET_PACKAGE_URL:-"http://downloads.puppetlabs.com/mac/puppet5/$OSX_VERSION/PC1/x86_64/puppet-agent-5.5.6-1.osx$OSX_VERSION.dmg"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is failing at line 45 - hdiutil attach

==> macos-client: Running provisioner: shell...
    macos-client: Running: /var/folders/q5/px6mvg0961ddsf72fgwsd_wc0000gn/T/vagrant-shell20181014-96552-9ykap7.sh
    macos-client: Installing: Puppet
    macos-client: -- Downloading DMG...
    macos-client: -- Mounting DMG...
    macos-client: hdiutil: attach failed - image not recognized
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

@ghoneycutt
Copy link
Collaborator

amazon201703-client fails because it is not mounting /vagrant. We should probably only be supporting the latest version of Amazon Linux. They do not seem to put an EOL on their versions and just encourage using the latest.

@ghoneycutt
Copy link
Collaborator

Both windows systems do not work. It seems like puppet is not in the PATH.

@treydock
Copy link
Collaborator Author

I've not found official amazon linux vagrant boxes so it's always been hit or miss if the community ones work. Amazon does release docker images.

@treydock
Copy link
Collaborator Author

Windows box fixed. Had to use x64 MSI instead of x86. The chocolatey one won't fully work as still no chocolatey packages for sensu.

Also added commit to address #994

@ghoneycutt
Copy link
Collaborator

@cwjohnston Are you looking to deploy to the chocolatey repo for windows users? It would really aid in adoption by making it easier to consume.

@ghoneycutt
Copy link
Collaborator

@treydock let me know when the macos-client is fixed and I'll re-test everything again.

@ghoneycutt ghoneycutt merged commit 911af23 into sensu:master Jan 1, 2019
@treydock treydock deleted the vagrant-puppet5 branch January 1, 2019 17:46
@ghoneycutt
Copy link
Collaborator

Released in v2.60.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants