Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make the spawn process limit configurable? #1002

Closed
ctheune opened this issue Jul 20, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@ctheune
Copy link

commented Jul 20, 2015

Hi,

I'm experimenting only at the moment but I'm running a bazillion lightweight checks and I see that I'm getting limited by the number of number spawnable processes (hardcoded to 12 in sensu-spawn).

My ruby isn't much good and this isn't urgent at all, but I'd like to know if you think this would be worthwhile. Maybe I can contribute in the future, but I'd also appreciate a patch if you think this is reasonable and easy to fix.

Cheers and thanks for the awesome stuff!

Christian

@portertech

This comment has been minimized.

Copy link
Member

commented Jul 20, 2015

@ctheune is the combined execution time great enough to create a backlog? How many checks are being scheduled for execution within such a tight time frame?

@ctheune

This comment has been minimized.

Copy link
Author

commented Jul 20, 2015

I'm probably being silly here. :)

I'm scheduling 1500 checks every 60 seconds (using nagios check_http), so, yeah, this creates a backlog because that list of URLs (I just took the top few thousands from Alexa) will contain things that have network issues and thus make check_http hang.

Nevertheless, configurable might be nice. :)

@ctheune

This comment has been minimized.

Copy link
Author

commented Jul 20, 2015

From a resource perspective this should be feasible, though. None of my resources (CPU, memory, disk, network, ...) are satured in any way.

@portertech

This comment has been minimized.

Copy link
Member

commented Jul 20, 2015

@ctheune I think making it configurable in the client definition is reasonable, going to label this issue as a feature 👍

@ctheune

This comment has been minimized.

Copy link
Author

commented Jul 20, 2015

Great, thanks. :)

@calebhailey calebhailey added this to the 0.24 milestone Apr 9, 2016

@calebhailey

This comment has been minimized.

Copy link
Member

commented Apr 9, 2016

#1184 is a duplicate of this, which we tagged for release in 0.24, so I'll do the same here and we'll close both of these at the same time.

@portertech

This comment has been minimized.

Copy link
Member

commented May 17, 2016

#1265 made the spawn limit configurable 👍

@portertech portertech closed this May 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.