Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API /results when the last client in the registry has no checks #1372

Merged
merged 1 commit into from Jul 13, 2016

Conversation

Projects
None yet
3 participants
@portertech
Copy link
Member

commented Jul 13, 2016

This pull request fixes #1356, using a Redis PING call to serialize the HTTP response, ensuring the response content includes all of the results.

I believe that /results is the only route that requires a change like this.

@portertech portertech changed the title Fix #1356 Fix API /results when the last client in the registry has no checks Jul 13, 2016

@amdprophet

This comment has been minimized.

Copy link
Member

commented Jul 13, 2016

👍

@cwjohnston

This comment has been minimized.

Copy link
Member

commented Jul 13, 2016

Serialize it! 👍

@portertech portertech merged commit b50ef7a into release/0.26 Jul 13, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@portertech portertech removed the in progress label Jul 13, 2016

@portertech portertech deleted the hotfix/api-results-serialize branch Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.