New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows interpolation fix #54

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@mlubej
Copy link
Contributor

mlubej commented Jan 21, 2019

Fixing the casting problem which results in interpolation problems on Windows machines. Rather simple fix. The problem was that the casting to float64 happened after the problem occurs on Windows, where the array overflows as int32, while on Linux/Unix it gets upcast automatically.

Perhaps some checks could be added to prevent if this occurs again in the future?

@AleksMat AleksMat merged commit b27021a into develop Jan 22, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@AleksMat AleksMat deleted the bugfix-windows-interpolation branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment