Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist sharing across users #522

Open
roobre opened this issue Jun 26, 2024 · 0 comments
Open

Playlist sharing across users #522

roobre opened this issue Jun 26, 2024 · 0 comments

Comments

@roobre
Copy link
Contributor

roobre commented Jun 26, 2024

gonic version: v0.16.4

Hi there!
Long time lurker of the Gonic project here, which has now regained some of my interest as recent changes to Jellyfin have unfortunately impacted a core use case for me: playlist sharing. I'm very much not a C# person myself, but I can handle Go just fine. Because of this, I would like to pitch this feature and offer my help to get it done in Gonic!

My current idea is very minimal: Allow a (potentially small) set of users to control playlists they do not own.

I've taken a quick look at the Gonic codebase, and I think this could be implemented on a first iteration by defining a playlist attribute in the likes of

#GONIC-SHARED-WITH 1,3,5

I think this should play nice with the existing attribute parser:

func decodeAttr(line string) (name, value string) {

With this list unmarshalled, it should hopefully be simple to tap into that list for consuming in

if playlist.UserID != user.ID && !playlist.IsPublic {

and for editing it in

if playlist.UserID != 0 && playlist.UserID != user.ID {

To keep the implementation small I was thinking about not exposing a method for granting access to playlists on the first iteration, and instead instruct users to add this comment manually to their m3u files.

Would love to hear your thoughts on this! If you think this could be useful, I'll be happy to spin up a PR with the suggested approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants