Add RequestBodyValidator. #11

Closed
wants to merge 1 commit into
from

2 participants

@myronmarston
Moz member

Can you review this, @proby?

@proby proby commented on the diff Oct 16, 2012
README.md
@@ -178,6 +180,13 @@ Interpol.default_configuration do |config|
halt 406, message
end
+ # Determines the response when the requested version is not available.
+ #
+ # Used by Interpol::RequestBodyValidator.
+ config.on_unavailable_request_version do |env, requested_version, available_versions|
@proby
proby added a line comment Oct 16, 2012

Maybe mention this is for all rack apps and how this and the sinatra version interact with each other? Which one gets run first? Can they both be set? Things like that.

@myronmarston
Moz member
myronmarston added a line comment Oct 16, 2012

It basically just that tools that are sinatra-focused use the sinatra one and tools that are rack-focused use this one.

The listing of tools that use the config option is given--did you notice that? Is there a better way to explain that?

@proby
proby added a line comment Oct 16, 2012

I did notice that but I misread it and convinced myself the two config options overlapped in their tool usage. Ignore me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@proby

merge it

@myronmarston
Moz member

Merged in 4f28f0c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment